[LUCENE-3485] LuceneTaxonomyReader .decRef() may close the inner IR, renderring the LTR in a limbo.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4
• Fix Version/s: 3.5, 4.0-ALPHA
• Component/s: modules/facet
• Lucene Fields: New, Patch Available
• Assignee: Shai Erera
• Reporter: Gilad Barkai
• Created: 04/Oct/11 13:32
• Updated: 28/Aug/22 12:58
• Resolved: 05/Oct/11 12:24

Description

TaxonomyReader which supports ref-counting, has a decRef() method which delegates to an inner IndexReader and calls its .decRef(). The latter may close the reader (if the ref is zeroes) but the taxonomy would remain 'open' which will fail many of its method calls.

Also, the LTR's .close() method does not work in the same manner as IndexReader's - which calls decRef(), and leaves the real closing logic to the decRef(). I believe this should be the right approach for the fix.