[LUCENE-2277] QueryNodeImpl throws ConcurrentModificationException on add(List<QueryNode>)

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.0
• Fix Version/s: 2.9.4, 3.0.3, 3.1, 4.0-ALPHA
• Component/s: modules/other

Environment

all

• Lucene Fields: New, Patch Available
• Assignee: Robert Muir
• Reporter: Frank Wesemann
• Created: 22/Feb/10 16:39
• Updated: 28/Aug/22 12:20
• Resolved: 29/Oct/10 14:25

Description

on adding a List of children to a QueryNodeImplemention a ConcurrentModificationException is thrown.
This is due to the fact that QueryNodeImpl instead of iteration over the supplied list, iterates over its internal clauses List.

Patch:
Index: QueryNodeImpl.java
===================================================================
— QueryNodeImpl.java (revision 911642)
+++ QueryNodeImpl.java (working copy)
@@ -74,7 +74,7 @@
.getLocalizedMessage(QueryParserMessages.NODE_ACTION_NOT_SUPPORTED));
}

• for (QueryNode child : getChildren()) {
  + for (QueryNode child : children) { add(child); }