[LUCENE-2030] CachingSpanFilter synchronizing on a none final protected object

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.9
• Fix Version/s: 3.0
• Component/s: core/search
• Lucene Fields: New, Patch Available
• Assignee: Uwe Schindler
• Reporter: Simon Willnauer
• Created: 04/Nov/09 17:08
• Updated: 28/Aug/22 12:13
• Resolved: 08/Nov/09 21:46

Description

CachingSpanFilter and CachingWrapperFilter expose their internal cache via a protected member which is lazily instantiated in the getDocSetId method. The current code yields the chance to double instantiate the cache and internally synchronizes on a protected none final member. My first guess is that this member was exposed for testing purposes so it should rather be changed to package private.

This patch breaks backwards compat while I guess the cleanup is kind of worth breaking it.