[LUCENE-1658] Absorb NIOFSDirectory into FSDirectory

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.9
• Component/s: core/store
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Michael McCandless
• Created: 24/May/09 16:10
• Updated: 28/Aug/22 12:01
• Resolved: 01/Jun/09 18:35

Description

I think whether one uses java.io.* vs java.nio.* or eventually
java.nio2.*, or some other means, is an under-the-hood implementation
detail of FSDirectory and doesn't merit a whole separate class.

I think FSDirectory should be the core class one uses when one's index
is in the filesystem.

So, I'd like to deprecate NIOFSDirectory, absorbing it into
FSDirectory, and add a setting "useNIO" to FSDirectory. It should
default to "true" for non-Windows OSs, because it gives far better
concurrent performance on all platforms but Windows (due to known Sun
JRE issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6265734).

Issue Links

• is depended upon by: LUCENE-1668 Trunk fails tests, FSD.open() - related
• relates to: LUCENE-1453 When reopen returns a new IndexReader, both IndexReaders may now control the lifecycle of the underlying Directory which is managed by reference counting