[#LUCENE-1552] IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag.

Lucene - Java

IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag.

Created: 04/Mar/09 08:40 PM Updated: 25/Sep/09 04:23 PM

Return to search

Component/s:

None

Affects Version/s:

2.4

Fix Version/s:

2.4.1, 2.9

Time Tracking:

Not Specified

Environment:

Java

Lucene Fields:	New
Resolution Date:	09/Mar/09 10:37 AM

Description

« Hide

After this bit of code in addIndexes(IndexReader[] readers)

try { flush(true, false, true); optimize(); // start with zero or 1 seg success = true; } finally { // Take care to release the write lock if we hit an // exception before starting the transaction if (!success) releaseWrite(); }

The success flag should be reset to "false" because it's used again in another try/catch/finally block.

TestIndexWriter.testAddIndexOnDiskFull() sometimes will hit this bug; but it's infrequent.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#750162	Wed Mar 04 21:34:53 UTC 2009	mikemccand	~~LUCENE-1552~~: reset success to false in addIndexes(IndexReader[])
				Files Changed
				MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/MultiReader.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexWriter.java

Repository	Revision	Date	User	Message
ASF	#750175	Wed Mar 04 21:53:46 UTC 2009	mikemccand	~~LUCENE-1552~~: reset success to false in addIndexes(IndexReader[])
				Files Changed
				MODIFY /lucene/java/branches/lucene_2_4/CHANGES.txt MODIFY /lucene/java/branches/lucene_2_4 MODIFY /lucene/java/branches/lucene_2_4/src/java/org/apache/lucene/index/IndexWriter.java

Repository	Revision	Date	User	Message
ASF	#780218	Sat May 30 09:34:37 UTC 2009	mikemccand	~~LUCENE-1552~~: properly index first token(s) with 0 position increment
				Files Changed
				MODIFY /lucene/java/branches/lucene_2_4_back_compat_tests/src/java/org/apache/lucene/index/IndexWriter.java MODIFY /lucene/java/branches/lucene_2_4_back_compat_tests/src/test/org/apache/lucene/index/TestIndexWriter.java

Repository	Revision	Date	User	Message
ASF	#780220	Sat May 30 09:36:10 UTC 2009	mikemccand	~~LUCENE-1552~~: properly index first token(s) with 0 position increment
				Files Changed
				MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/DocumentsWriter.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/DocInverterPerField.java MODIFY /lucene/java/trunk/src/test/org/apache/lucene/search/TestPositionIncrement.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexWriter.java MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/DocumentsWriterThreadState.java MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexWriter.java MODIFY /lucene/java/trunk/CHANGES.txt MODIFY /lucene/java/trunk/common-build.xml