Issue Details (XML | Word | Printable)

Key: LUCENE-1350
Type: Bug Bug
Status: Closed Closed
Resolution: Duplicate
Priority: Major Major
Assignee: Doron Cohen
Reporter: Doron Cohen
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Lucene - Java

Filters which are "consumers" should not reset the payload or flags and should better reuse the token

Created: 05/Aug/08 08:36 AM   Updated: 11/Oct/08 12:49 PM
Return to search
Component/s: Analysis, contrib/*
Affects Version/s: None
Fix Version/s: 2.4

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works LUCENE-1350-test.patch 2008-08-11 09:26 AM Doron Cohen 1 kB
Text File Licensed for inclusion in ASF works LUCENE-1350.patch 2008-08-08 08:44 PM DM Smith 118 kB
Text File Licensed for inclusion in ASF works LUCENE-1350.patch 2008-08-05 08:40 AM Doron Cohen 0.7 kB
Issue Links:
Incorporates
 
Reference
 

Lucene Fields: Patch Available, New
Resolution Date: 03/Sep/08 09:42 PM


 Description  « Hide
Passing tokens with payloads through SnowballFilter results in tokens with no payloads.
A workaround for this is to apply stemming first and only then run whatever logic creates the payload, but this is not always convenient.

Other "consumer" filters have similar problem.

These filters can - and should - reuse the token, by implementing next(Token), effectively also fixing the unwanted resetting.



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Doron Cohen made changes - 05/Aug/08 08:40 AM
Field Original Value New Value
Attachment LUCENE-1350.patch [ 12387545 ]
Tricia Williams made changes - 05/Aug/08 06:33 PM
Link This issue relates to SOLR-532 [ SOLR-532 ]
DM Smith made changes - 06/Aug/08 09:48 PM
Link This issue blocks LUCENE-1333 [ LUCENE-1333 ]
Doron Cohen made changes - 07/Aug/08 07:09 AM
Description Passing tokens with payloads through SnowballFilter results in tokens with no payloads.
A workaround for this is to apply stemming first and only then run whatever logic creates the payload, but this is not always convenient.
Patch to follow that preserves the payload.
Passing tokens with payloads through SnowballFilter results in tokens with no payloads.
A workaround for this is to apply stemming first and only then run whatever logic creates the payload, but this is not always convenient.

Other "consumer" filters have similar problem.

These filters can - and should - reuse the token, by implementing next(Token), effectively also fixing the unwanted resetting.
Lucene Fields [Patch Available, New] [New, Patch Available]
Fix Version/s 2.3.3 [ 12313327 ]
Summary SnowballFilter resets the payload Filters which are "consumers" should not reset the payload or flags and should better reuse the token
DM Smith made changes - 08/Aug/08 08:44 PM
Attachment LUCENE-1350.patch [ 12387850 ]
Doron Cohen made changes - 11/Aug/08 09:22 AM
Link This issue blocks LUCENE-1333 [ LUCENE-1333 ]
Doron Cohen made changes - 11/Aug/08 09:24 AM
Link This issue is part of LUCENE-1333 [ LUCENE-1333 ]
Doron Cohen made changes - 11/Aug/08 09:26 AM
Attachment LUCENE-1350-test.patch [ 12387937 ]
Mark Miller made changes - 19/Aug/08 01:12 PM
Fix Version/s 2.4 [ 12312681 ]
Michael McCandless made changes - 03/Sep/08 09:42 PM
Resolution Duplicate [ 3 ]
Fix Version/s 2.3.3 [ 12313327 ]
Lucene Fields [Patch Available, New] [New, Patch Available]
Status Open [ 1 ] Resolved [ 5 ]
Michael McCandless made changes - 11/Oct/08 12:49 PM
Status Resolved [ 5 ] Closed [ 6 ]