Issue Details (XML | Word | Printable)

Key: LUCENE-1314
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Michael McCandless
Reporter: Jason Rutherglen
Votes: 1
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
Lucene - Java

IndexReader.clone

Created: 23/Jun/08 04:27 PM   Updated: 25/Sep/09 04:23 PM
Return to search
Component/s: Index
Affects Version/s: 2.3.1
Fix Version/s: 2.9

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-02-27 09:04 PM Michael McCandless 14 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-02-26 07:41 PM Jason Rutherglen 0.9 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-02-09 06:34 PM Jason Rutherglen 4 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-02-07 07:29 PM Michael McCandless 3 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-02-06 10:42 PM Jason Rutherglen 1 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-26 09:29 PM Michael McCandless 91 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-18 04:26 PM Michael McCandless 90 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-16 11:24 PM Jason Rutherglen 82 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-16 09:56 PM Jason Rutherglen 82 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-16 07:59 PM Jason Rutherglen 82 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-16 04:41 PM Jason Rutherglen 82 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-16 03:32 AM Jason Rutherglen 82 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-13 09:43 PM Jason Rutherglen 61 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-11 10:45 PM Michael McCandless 76 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-08 09:22 PM Jason Rutherglen 49 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-07 04:41 AM Jason Rutherglen 48 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2009-01-05 11:05 PM Jason Rutherglen 45 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2008-12-23 07:11 PM Jason Rutherglen 41 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2008-12-23 04:33 PM Jason Rutherglen 40 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2008-12-22 06:33 PM Jason Rutherglen 40 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2008-12-19 02:21 AM Jason Rutherglen 36 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2008-12-12 06:44 PM Jason Rutherglen 34 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2008-12-10 11:36 PM Jason Rutherglen 18 kB
Text File Licensed for inclusion in ASF works LUCENE-1314.patch 2008-12-10 11:02 PM Jason Rutherglen 17 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-09-17 01:30 PM Jason Rutherglen 44 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-07-16 02:44 PM Jason Rutherglen 41 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-07-10 02:11 PM Jason Rutherglen 39 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-07-08 05:52 PM Jason Rutherglen 39 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-07-08 05:49 PM Jason Rutherglen 29 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-07-07 01:10 PM Jason Rutherglen 35 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-07-03 11:48 AM Michael McCandless 20 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-07-02 10:05 PM Jason Rutherglen 21 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-06-29 03:17 PM Jason Rutherglen 21 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-06-24 04:55 PM Jason Rutherglen 16 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-06-24 03:38 PM Jason Rutherglen 16 kB
Text File Licensed for inclusion in ASF works lucene-1314.patch 2008-06-23 05:13 PM Jason Rutherglen 13 kB

Lucene Fields: New
Resolution Date: 01/Mar/09 12:12 PM


 Description  « Hide
Based on discussion http://www.nabble.com/IndexReader.reopen-issue-td18070256.html. The problem is reopen returns the same reader if there are no changes, so if docs are deleted from the new reader, they are also reflected in the previous reader which is not always desired behavior.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #739238 Fri Jan 30 11:12:48 UTC 2009 mikemccand LUCENE-1314: add IndexReader.clone(boolean readOnly) and reopen(boolean readOnly)
Files Changed
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/MultiReader.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/DocumentsWriter.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/ReadOnlyMultiSegmentReader.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/SegmentReader.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/MultiSegmentReader.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexReader.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/ParallelReader.java
ADD /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReaderClone.java
MODIFY /lucene/java/trunk/CHANGES.txt
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/store/SingleInstanceLockFactory.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/DirectoryIndexReader.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReaderReopen.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/util/BitVector.java
ADD /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReaderCloneNorms.java

Repository Revision Date User Message
ASF #741838 Sat Feb 07 03:30:24 UTC 2009 yonik LUCENE-1314: fix reopen bug wrt fields that don't have norms
Files Changed
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/SegmentReader.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReaderReopen.java

Repository Revision Date User Message
ASF #744653 Sun Feb 15 10:56:36 UTC 2009 mikemccand LUCENE-1314: allow clone of subreaders; add note to getSequentialSubReaders javadoc to not use sub-readers to make changes
Files Changed
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/SegmentReader.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/IndexReader.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReaderClone.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/DirectoryIndexReader.java

Repository Revision Date User Message
ASF #746343 Fri Feb 20 19:37:25 UTC 2009 mikemccand LUCENE-1314: add asserts during *Reader.clone() that the incoming SegmentInfo/s matches the current reader
Files Changed
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/SegmentReader.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/MultiSegmentReader.java

Repository Revision Date User Message
ASF #748998 Sun Mar 01 11:13:07 UTC 2009 mikemccand LUCENE-1314: fix ref-count tests in TestIndexReaderReopen
Files Changed
MODIFY /lucene/java/branches/lucene_2_4_back_compat_tests/src/test/org/apache/lucene/index/TestIndexReaderReopen.java

Repository Revision Date User Message
ASF #749000 Sun Mar 01 11:28:41 UTC 2009 mikemccand LUCENE-1314: fix ref-count tests in TestIndexReaderReopen, take 2
Files Changed
MODIFY /lucene/java/branches/lucene_2_4_back_compat_tests/src/test/org/apache/lucene/index/TestIndexReaderReopen.java

Repository Revision Date User Message
ASF #749009 Sun Mar 01 12:12:36 UTC 2009 mikemccand LUCENE-1314: change reference counting to properly track deleted docs & shared core readers inside SegmentReader
Files Changed
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/index/SegmentReader.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReaderClone.java
MODIFY /lucene/java/trunk/src/test/org/apache/lucene/index/TestIndexReaderReopen.java
MODIFY /lucene/java/trunk/src/java/org/apache/lucene/util/BitVector.java
MODIFY /lucene/java/trunk/common-build.xml