[LUCENE-129] Finalizers are non-canonical

• Type: Bug
• Status: Reopened
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.1
• Component/s: core/other

Environment

Operating System: other
Platform: All

• Bugzilla Id: 24084
• Assignee: Michael McCandless
• Reporter: Esmond Pitt
• Created: 24/Oct/03 09:02
• Updated: Yesterday 13:42
• Resolved: 19/Dec/06 11:36

Description

The canonical form of a Java finalizer is:

protected void finalize() throws Throwable()
{
try

{ // ... local code to finalize this class }

catch (Throwable t)
{
}
super.finalize(); // finalize base class.
}

The finalizers in IndexReader, IndexWriter, and FSDirectory don't conform. This
is probably minor or null in effect, but the principle is important.

As a matter of fact FSDirectory.finaliz() is entirely redundant and could be
removed, as it doesn't do anything that RandomAccessFile.finalize would do
automatically.