Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-10661

Reduce memory copy in BytesStore

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 9.4
    • None
    • None
    • New

    Description

      This is derived from LUCENE-10627(https://github.com/apache/lucene/pull/987) AND LUCENE-10657(https://github.com/apache/lucene/pull/1034)

      The abstract method copyBytes in DataOutput have to copy from input to a copyBuffer and then write into BytesStore.blocks, which is called in FST initialization read from metaIn. 

      Although, this copy bytes only a few bytes (in the testscase only 3-10 bytes), i think we can save this memory copy, just save the DataOutput.copyBytes to create new copyBuffer with 16384 bytes

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              luyuncheng LuYunCheng
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h

                  Slack

                    Issue deployment