[LUCENE-10644] Facets#getAllChildren testing should ignore child order

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.4
• Component/s: modules/facet
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Greg Miller
• Created: 06/Jul/22 20:23
• Updated: 28/Aug/22 16:43
• Resolved: 18/Aug/22 18:03

Description

Our javadoc for Facets#getAllChildren explicitly calls out that callers should make no assumptions about child ordering, but a number of our own unit tests turn around and make that assumption. I ran into this when recently trying an optimization that would result in a different child ordering for getAllChildren, and found a number of unit tests that started failing. I'll upload a list of what I found failing.

Issue Links

• links to: GitHub Pull Request #1013