[LUCENE-10618] Implement BooleanQuery rewrite rules based for minimumShouldMatch

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.3
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Adrien Grand
• Created: 15/Jun/22 08:18
• Updated: 28/Aug/22 16:42
• Resolved: 20/Jun/22 12:09

Description

While looking into a test failure I noticed that we sometimes create weights for boolean queries with no SHOULD clauses and a non-zero minimumNumberShouldMatch.

We could rewrite BooleanQuery to MatchNoDocsQuery when the number of SHOULD clauses is less than minimumNumberShouldMatch, and make SHOULD clauses required when the number of SHOULD clauses is equal to minimumNumberShouldMatch.

This feels a bit like a degenerate case (why would the use create such a query in the first place?) but this case can also happen to non-degenerate queries if some SHOULD clauses rewrite to a MatchNoDocsQuery and get removed through rewrite.

Issue Links

• links to: GitHub Pull Request #965