[LUCENE-10564] SparseFixedBitSet#or doesn't update memory accounting

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.11.2, 9.2
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Julie Tibshirani
• Created: 10/May/22 04:12
• Updated: 28/Aug/22 16:40
• Resolved: 12/May/22 20:54

Description

While debugging why a cache was using way more memory than expected, one of my colleagues noticed that SparseFixedBitSet#or doesn't update ramBytesUsed. Here's a unit test that demonstrates this:

  public void testRamBytesUsed() throws IOException {
    BitSet bitSet = new SparseFixedBitSet(1000);
    long initialBytesUsed = bitSet.ramBytesUsed();

    DocIdSetIterator disi = DocIdSetIterator.all(1000);
    bitSet.or(disi);
    assertTrue(bitSet.ramBytesUsed() > initialBytesUsed);
  }

It also looks like we don't have any tests for SparseFixedBitSet memory accounting (unless I've missed them!) It'd be nice to add more coverage there too.

Issue Links

• links to: GitHub Pull Request #882