[LUCENE-1046] Dead code in SpellChecker.java (branch never executes)

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.2
• Component/s: modules/spellchecker
• Lucene Fields: New, Patch Available
• Assignee: Otis Gospodnetic
• Reporter: Joe
• Created: 03/Nov/07 23:34
• Updated: 28/Aug/22 11:42
• Resolved: 22/May/08 06:36

Description

SpellChecker contains the following lines of code:

final int goalFreq = (morePopular && ir != null) ? ir.docFreq(new Term(field, word)) : 0;
// if the word exists in the real index and we don't care for word frequency, return the word itself
if (!morePopular && goalFreq > 0) {
return new String[]

{ word }

;
}

The branch will never execute: the only way for goalFreq to be greater than zero is if morePopular is true, but if morePopular is true, the expression in the if statement evaluates to false.