Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-10381

Require users to provide FacetsConfig with initializing DefaultSortedSetDocValuesReaderState

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 9.1, 10.0 (main)
    • modules/facet
    • None
    • New

    Description

      In LUCENE-10250, we added the ability for users to provide their FacetsConfig when constructing DefaultSortedSetDocValuesReaderState. This is necessary for some of the new functionality and bug fixes in SSDV faceting (e.g., we need to know if a dim is configured as hierarchical, multivalued and/or requiring dim counts). To remain backwards-compatible, existing ctors were maintained and users don't need to provide config, which means we have to fall back to some default (pre-existing) behavior if we don't have the config.

      We should make the config mandatory going forward so that users always explicitly provide their config. This is consistent with taxonomy faceting where users must provide config. It's also pretty trappy to let users setup their state without config as they might just overlook the need to provide it.

      Attachments

        Activity

          People

            Unassigned Unassigned
            gsmiller Greg Miller
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h
                1h