[LUCENE-10353] Add null injection to analyzer integration tests (e.g. TestRandomChains)

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.1, 10.0 (main)
• Labels: random-chains
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Robert Muir
• Created: 04/Jan/22 16:16
• Updated: 28/Aug/22 16:34
• Resolved: 06/Jan/22 15:59

Description

These tests inject random parameter values (from argumentProviders). Some generated values may be illegal and IllegalArgumentException is "allowed" if the constructor returns it. None of the values should cause failures at runtime.

But for object types, we never inject null values (unless the argumentProvider were to do it itself). We should do this some low % of the time, and "allow" ctors to return NPE too.

I see bugs in some of the analyzers where they are just a missing null check in the constructor. It is important to fail on invalid configuration up-front in the ctor, rather than failing e.g. at index time.

Issue Links

• links to: GitHub Pull Request #586