[LUCENE-10252] ValueSource.asDoubleValues shouldn't fetch score

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.1
• Component/s: modules/query
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 23/Nov/21 04:36
• Updated: 28/Aug/22 16:30
• Resolved: 03/Jan/22 13:35

Description

The ValueSource.asDoubleValuesSource() method bridges the old API to the new one.  It's rather important because boosting a query no longer has an old API; in its place is using this method and passing to FunctionScoreQuery.boostByValue.  Unfortunately, asDoubleValuesSource will fetch/compute the score for the document in order to expose it in a Scorable on the "scorer" key of the context Map.  AFAICT nothing in Lucene or Solr actually uses this.  If it should be kept, the Scorable's score() method could fetch it at that time (e.g. on-demand).

Issue Links

• is caused by: LUCENE-8099 Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery
• is related to: SOLR-12407 edismax boost performance regression from switch to FunctionScoreQuery
• links to: GitHub Pull Request #519