[LUCENE-10114] Remove unused byte order mark in Lucene90PostingsWriter

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 9.0
• Fix Version/s: 9.0
• Component/s: core/codecs, core/index
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 19/Sep/21 21:43
• Updated: 28/Aug/22 16:26
• Resolved: 08/Dec/21 17:06

Description

While reviewing the byte order in lucene index, I found the following code in Lucene90PostingsWriter:

ByteOrder byteOrder = ByteOrder.nativeOrder();
if (byteOrder == ByteOrder.BIG_ENDIAN) {
  docOut.writeByte((byte) 'B');
} else if (byteOrder == ByteOrder.LITTLE_ENDIAN) {
  docOut.writeByte((byte) 'L');
} else {
  throw new Error();
}

Actually this byte is consumed nowhere, as the file is only used via seeking and the offsets are just 1 larger. We should remove this code.

Why was this added?

Issue Links

• links to: GitHub Pull Request #309