[LOG4PHP-11] trailing "\n"

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0

Environment

PHP5.2.5

• Assignee: Unassigned
• Reporter: Hiroaki Kawai
• Created: 06/Mar/08 05:49
• Updated: 01/Dec/13 10:56
• Resolved: 08/Mar/08 20:19

Description

While I was looking around the files, I found that the files contains unwanted trailing "\n". The files should end with "?>" and not "?>\n".

If we have a trailing \n, php will send a "\n" as a content, and this cause some functions such as header(), won't work properly.

Another style may be a Zend Framework style that doesn't have ending "?>".
http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html#coding-standard.php-file-formatting.general

---------------------
I got a feedback about this at [e-mail], that we prefer
zend-framework style formatting from Curt Arnold <carnold_at_apache.org> and "Michael Gall" <michael_at_wakeless.net>.