[LOG4PHP-102] LoggerLayoutPattern fails tests

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.1.0
• Component/s: Code
• Assignee: Unassigned
• Reporter: Ivan Habunek
• Created: 14/Mar/10 13:59
• Updated: 02/May/23 16:24
• Resolved: 22/Mar/10 06:41

Description

In LoggerLayoutPatternTest class, the testWarnLayout() method is commented out because it fails with the following message:

1) testWarnLayout(LoggerLayoutPatternTest)
Undefined index: log4php.LoggerPatternConverter.spaces
/Users/cgrobmeier/Documents/Development/workspace/log4php-trunk/src/main/php/helpers/LoggerPatternConverter.php:131
/Users/cgrobmeier/Documents/Development/workspace/log4php-trunk/src/main/php/helpers/LoggerPatternConverter.php:104
/Users/cgrobmeier/Documents/Development/workspace/log4php-trunk/src/main/php/layouts/LoggerPatternLayout.php:216
/Users/cgrobmeier/Documents/Development/workspace/log4php-trunk/src/test/php/layouts/LoggerLayoutPatternTest.php:45

This seems to be related to using a global variable $GLOBALS['log4php.LoggerPatternConverter.spaces'] in LoggerPatternConverter::spacePad(). I am unsure why the global variable is not accessible in this test, but using a global variable seems the wrong approach here anyway.