[LANG-990] Avoid String allocation in StrBuilder.append(CharSequence)

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.1
• Fix Version/s: 3.4
• Component/s: lang.text.*
• Labels: github
• Assignee: Benedikt Ritter
• Reporter: Mikhail Mazursky
• Created: 21/Mar/14 04:10
• Updated: 06/Apr/15 17:28
• Resolved: 14/Mar/15 12:25

Description

StrBuilder.append(CharSequence) and StrBuilder.append(CharSequence, int, int) can be optimized for the case when CharBuffer is passed. Current implementation calls toString() method that allocates a new String. In case when CharBuffer.hasArray() returns true the buffer-backing char array can be accessed directly to copy chars from it.

Also an instanceOf StrBuilder check can be added to StrBuilder.append(CharSequence) and StrBuilder.append(CharSequence, int, int) to avoid toString() in that case too (StrBuilder can be passed as CharSequence in some cases).