Uploaded image for project: 'Commons Lang'
  1. Commons Lang
  2. LANG-585

exception.DefaultExceptionContext.getFormattedExceptionMessage catches Throwable

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 3.0
    • lang.exception.*
    • None

    Description

      It's generally a bad idea to catch Throwable.

      The getFormattedExceptionMessage method should be changed to catch less; e.g. Exception + RuntimeException should be adequate.

      The Javadoc examples in ContextedException and ContextedRuntimeException suggest catching Throwable; these examples should be changed too.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            sebb Sebb
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment