[KYLIN-3578] Do not synchronize on the intrinsic locks of high-level concurrency objects

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: v2.6.0
• Assignee: Xiaoxiang Yu
• Reporter: Ted Yu
• Created: 23/Sep/18 17:27
• Updated: 12/Jan/19 06:41
• Resolved: 07/Nov/18 07:22

Description

From core-common/src/main/java/org/apache/kylin/common/util/MemoryBudgetController.java :

    private final ReentrantLock lock = new ReentrantLock();
...
            synchronized (lock) {

See the following for why such practice is to be avoided:

https://wiki.sei.cmu.edu/confluence/display/java/LCK03-J.+Do+not+synchronize+on+the+intrinsic+locks+of+high-level+concurrency+objects

Issue Links

• links to: GitHub Pull Request #253