[KYLIN-3505] DataType.getType wrong usage of cache

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: v2.4.1, v2.5.0
• Component/s: Metadata
• Assignee: Ian Hu
• Reporter: Ian Hu
• Created: 21/Aug/18 09:21
• Updated: 09/Sep/18 05:53
• Resolved: 21/Aug/18 11:02

Description

Wrong usage of cache in org.apache.kylin.metadata.datatype.DataType#getType.

public static DataType getType(String type) {
    if (type == null)
        return null;

    DataType dataType = new DataType(type); // <-- Always new
    DataType cached = CACHE.get(dataType); // already has dataType why fetch it from cache?
    if (cached == null) {
        CACHE.put(dataType, dataType); // <-- Seed cache
        cached = dataType;
    }
    return cached;
}

Issue Links

• links to: GitHub Pull Request #206