[KYLIN-3481] Kylin Jdbc: Shaded dependencies should not be transitive

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: v2.4.0
• Fix Version/s: v2.5.0
• Component/s: Driver - JDBC
• Assignee: Ian Hu
• Reporter: Ian Hu
• Created: 03/Aug/18 04:17
• Updated: 17/Sep/18 00:59
• Resolved: 07/Aug/18 15:06

Description

kylin-jdbc use dependencies as shaded, so they should not be transitive.

As far as I known, SHADE a dependency to avoid dependency conflict, but at v2.4.0, the dependencies in kylin-jdbc are default compile scope and are transitive resolved, that may cause some dependency conflicts.

We should mark shaded dependencies as optional

 

There are two solutions about the fixation:

1. mark dependency as `optional`
2. or change the dependency scope to provided, and add shade artifactSets with include

<dependency>
    <groupId>org.apache.httpcomponents</groupId>
    <artifactId>httpclient</artifactId>
    <optional>true</optional> // add this
</dependency>

// ============= or =============
<dependency>
    <groupId>org.apache.httpcomponents</groupId>
    <artifactId>httpclient</artifactId>
    <scope>provided</scope>
</dependency>
// and
<artifactSet>
    <excludes>
        <exclude>org.slf4j:jcl-over-slf4j:*</exclude>
    </excludes>
    <includes>
        <include>org.apache.httpcomponents:httpclient:*</include> // force include provided scope
        <include>org.apache.calcite.avatica:avatica-core:*</include> // force include provided scope 
    </includes>
</artifactSet>

 

 

Issue Links

• links to: GitHub Pull Request #185