[KUDU-2889] Per-row error indication in prepare phase

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 0.10.0
• Fix Version/s: NA
• Component/s: tserver
• Assignee: Yingchun Lai
• Reporter: Yingchun Lai
• Created: 10/Jul/19 07:07
• Updated: 12/Jul/19 03:53
• Resolved: 12/Jul/19 03:53

Description

In prepare phase of write path, some row data may have some errors, like missing a non-nullable field value, then the whole batch will fail, even if the other rows have no errors.

It's a kind of waste, we should take best effect for the batch as how it work in apply phase, partial rows errors should not fail the whole batch operation.

 

For example, these code can be improved:

https://github.com/apache/kudu/blob/master/src/kudu/common/row_operations.cc#L387

      if (PREDICT_FALSE(!(col.is_nullable() || col.has_write_default()))) {
	// TODO: change this to return per-row errors. Otherwise if one row in a batch
	// is missing a field for some reason, the whole batch will fail.
	return Status::InvalidArgument("No value provided for required column",
	col.ToString());
      }

Issue Links

• duplicates: KUDU-2625 Unexpected behavior of WriteBatch wrt rows violating schema constraints