[KAFKA-5446] Annoying braces showed on log.error using streams

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.11.0.0
• Fix Version/s: 0.11.0.0
• Component/s: streams
• Assignee: Paolo Patierno
• Reporter: Paolo Patierno
• Created: 14/Jun/17 13:39
• Updated: 16/Jun/17 23:10
• Resolved: 16/Jun/17 23:10

Description

Hi,
in the stream library seems to be a wrong usage of the log.error method when we want to show an exception. There are useless braces at the end of the line before showing exception information like the following example :

ERROR task [0_0] Could not close task due to {} (org.apache.kafka.streams.processor.internals.StreamTask:414)
org.apache.kafka.clients.consumer.CommitFailedException: Commit cannot be completed since the group has already rebalanced and assigned the partitions to another member. This means that the time between subsequent calls to poll() was longer than the configured max.poll.interval.ms, which typically implies that the poll loop is spending too much time message processing. You can address this either by increasing the session timeout or by reducing the maximum size of batches returned in poll() with max.poll.records.
at org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.sendOffsetCommitRequest(ConsumerCoordinator.java:725)
at org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.commitOffsetsSync(ConsumerCoordinator.java:604)
at org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1146)

as you can see in ".... due to {}", the braces aren't needed for showing exception info so they are printed.

Thanks,
Paolo.

Issue Links

• links to: GitHub Pull Request #3338