[KAFKA-15639] Investigate ConsumerNetworkThreadTest's testResetPositionsProcessFailureIsIgnored

• Type: Test
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Fix Version/s: 3.8.0
• Component/s: clients, consumer, unit tests
• Labels: consumer-threading-refactor unit-tests
• Assignee: Unassigned
• Reporter: Kirk True
• Created: 18/Oct/23 23:55
• Updated: 07/Feb/24 20:31

Description

The testResetPositionsProcessFailureIsIgnored test looks like this:

 

    @Test
    public void testResetPositionsProcessFailureIsIgnored() {
        doThrow(new NullPointerException()).when(offsetsRequestManager).resetPositionsIfNeeded();

        ResetPositionsApplicationEvent event = new ResetPositionsApplicationEvent();
        applicationEventsQueue.add(event);
        assertDoesNotThrow(() -> consumerNetworkThread.runOnce());

        verify(applicationEventProcessor).process(any(ResetPositionsApplicationEvent.class));
    }
 

 

junrao asks:

 

Not sure if this is a useful test since offsetsRequestManager.resetPositionsIfNeeded() seems to never directly throw an exception?

 

I commented out the doThrow line and it did not impact the test.