[KAFKA-14615] Use sizeCompare(Iterable[_]) to compare two iterables

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Fix Version/s: 4.0.0
• Labels: Newbie newbie
• Assignee: Kamalesh Palanisamy
• Reporter: Divij Vaidya
• Created: 11/Jan/23 15:49
• Updated: 27/Jan/23 16:49

Description

Since Scala 2.12 is being deprecated in 4.x version, we can utilize some improved methods for comparing size of scala collections which were introduced starting 2.13.

This task is to find and replace usage of code paths where we use (IterableA.size == IterableB.size) having a complexity of O(IterableA size + IterableB size) with sizeCompare() method which has a complexity of O(min(IterableA size, IterableB size))

Some examples where sizeCompare() could be used are:
1. https://github.com/apache/kafka/blob/78d4458b94e585bc602a4ae307d3de54fcedf2af/core/src/main/scala/kafka/server/KafkaApis.scala#L1177
2. https://github.com/apache/kafka/blob/78d4458b94e585bc602a4ae307d3de54fcedf2af/core/src/main/scala/kafka/tools/JmxTool.scala#L215 
3. 

 [1] https://github.com/scala/scala/pull/6758
 [2] https://github.com/scala/scala/pull/6950 

Issue Links

• is part of: KAFKA-12895 KIP-751: Drop support for Scala 2.12 in Kafka 4.0 (deprecate in 3.0)