[PATCH] Weather portlet influences other portlets' state

• Key: JS1-404
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Blocker
• Assignee: Unassigned
• Reporter: Olaf Romanski
• Component/s: Portlets
• Affects Version/s: 1.4
• Fix Version/s: 1.5

Environment

Operating System: Windows NT/2K
Platform: PC

Description

To reproduce that error:
1.Customize your page so that it contains Weather portlet (or any derived) and
at least one other portlet (for more informative example, two others)
2.Click "Minimize" on any non-weather portlet
3.Click "Minimize" on second non-weather portlet
Expected result:
Minimized portlets remain minimized.
Real result:
Previously minimized portlet is displayed in normal mode again. (Alternatively
to minimizing two portlets, you may minimize one, switch to another pane, move
back to the first pane. The results will be identical.)

Here is what I have learned from my investigation:
1. The reason is, that current user's PSML is written by "Minimize" action and
then overwritten with invalid (old) content by buildNormalContext method of
WeatherAction class
2. The line of code that is causing problem:
PortletConfigState.setInstanceParameter(portlet, rundata, WEATHER_CITY_INFO,
cityInfo);

I think that the above line is excessive, and somewhat incompatible
with general JS patterns.

Comments

[Olaf Romanski]

Created an attachment (id=8817)
proposed patch

[Mark Orciuch]

Patch applied and tested.