[JELLY-96] HttpClient cannot be specified in HttpSession

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0-beta-5
• Component/s: taglib.http
• Assignee: Unassigned
• Reporter: Jason Horne
• Created: 11/Nov/03 23:42
• Updated: 12/Sep/04 15:43
• Resolved: 12/Sep/04 15:43

Description

org.apache.commons.jelly.tags.http.SessionTag always creates a new HttpClient rather than using one provided by the user.

The doTag method should be changed from this:

public void doTag(XMLOutput xmlOutput) throws JellyTagException {
if (isProxyAvailable())

{ _httpClient = new HttpClient(); _httpClient.getHostConfiguration().setProxy(getProxyHost(), getProxyPort()); }

else

{ _httpClient = new HttpClient(); }

...to this:

public void doTag(XMLOutput xmlOutput) throws JellyTagException {
if (_httpClient == null)
_httpClient = new HttpClient();

if (isProxyAvailable())

{ _httpClient.getHostConfiguration().setProxy(getProxyHost(), getProxyPort()); }

invokeBody(xmlOutput);
}