[JELLY-202] PatternSet's toString gives NPE

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.0
• Component/s: taglib.ant
• Assignee: Unassigned
• Reporter: Paul Libbrecht
• Created: 16/Feb/05 18:48
• Updated: 16/Feb/05 18:48

Description

When the logging-level is set to Debug and org.apache.commons.jelly.tags.ant.AntTag is setting properties (actually, before setting the properties) on the ant-tag, the following is attempted:
log.debug( "Setting bean property on: "+ object + " name: " + name + " value: " + value );
which fails with a null-pointer for the following reason which I partially share:
The toString of object is invoked and, if this one is a org.apache.tools.ant.types.PatternSet (or its inner class), it throws because the name is not set yet. It's not set yet because it's going to be set !

I considered this as a bug, to me, toString() should never throw.
Jelly-Ant's ant version is a bit old so I hoped a later version of Ant fixes this. By no means!
In todays snapshot, one can see the following:
if (name == null)

{ throw new BuildException( "Missing attribute \"name\" for a pattern"); }

I'd propose, thus, to remove the object from the debug line above until we manage to convince anters and we upgrade.
log.debug( "Setting bean property on name: " + name + " value: " + value );

paul