[JCS-140] JCacheFilter code logic error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: jcs-2.0-beta-2
• Assignee: Romain Manni-Bucau
• Reporter: liangjiarui
• Created: 04/Jan/15 09:25
• Updated: 25/Dec/16 18:35
• Resolved: 01/Apr/15 17:01

Description

final PageKey key = new PageKey(key(servletRequest), gzip);
Page page = cache.get(key);
if (page == null)

{ .... }

if (page.status == SC_OK) {
checkResponse(httpServletResponse);

the last line always throw exception for the first time the specified url is requested,because the response is commited in the previous if.

I think the logic of doFilter should be like this:

String key=getKeyFromRequest();
Page page=cache.get(key);
if(page==null){
chain.doFilter();
cache.put(key,response);
}else{
response.write(cache);
}