[JAMES-78] NullPointerException in org.apache.james.smtpserver.SMTPHandler

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 2.1
• Component/s: SMTPServer
• Environment: Operating System: Solaris; Platform: Sun
• Bugzilla Id: 15831
• Assignee: Unassigned
• Reporter: Marcos Sanz
• Created: 07/Jan/03 17:43
• Updated: 06/Jun/04 21:09
• Resolved: 06/Jun/04 21:09

Description

I have some NullPointerExceptions in my log file because of this line:

final String readCommandLine() throws IOException {
return inReader.readLine().trim();
}

Wouldn't it be much smarter:

final String readCommandLine() throws IOException {
String line = inReader.readLine();
if (null == line)
return null;
else
return line.trim();
}

I don't think it breaks any code this way.