[#JAMES-671] ServerConnection doesn't properly handle the TCP/IP backlog

JAMES Server

ServerConnection doesn't properly handle the TCP/IP backlog

Created: 04/Nov/06 06:24 PM Updated: 21/Nov/07 08:31 AM

Return to search

Component/s:

James Core

Affects Version/s:

2.2.0, 2.3.0

Fix Version/s:

2.3.1

Time Tracking:

Not Specified

Resolution Date:

12/Jan/07 11:07 AM

Description

« Hide

ServerConnection calls accept() even when the configured connection limit has been reached, thereby purging the TCP/IP backlog and expending cycles in the process. This is inefficient, drops connections, and renders the backlog configuration setting largely worthless.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#471243	Sat Nov 04 18:28:53 UTC 2006	noel	~~JAMES-671~~. Don't accept() unless we're prepared to process the connection. This change is perhaps excessively conservative. We can probably eliminate the loop and the timeout value for wait (which is just a backstop), and just rely upon notification.
				Files Changed
				MODIFY /james/server/trunk/src/java/org/apache/james/util/connection/ServerConnection.java

Stefano Bagnara made changes - 20/Nov/06 04:40 PM

Field	Original Value	New Value
Fix Version/s	Trunk [ 12312135 ]

[ Permlink | « Hide ]

Stefano Bagnara added a comment - 20/Nov/06 04:41 PM

this is fixed in svn-trunk (next-major).
The issue is still open because it could be backported to next-minor.

Repository	Revision	Date	User	Message
ASF	#495552	Fri Jan 12 11:06:09 UTC 2007	norman	Merge changes for ~~JAMES-671~~
				Files Changed
				MODIFY /james/server/branches/v2.3/src/test/org/apache/james/smtpserver/SMTPTestConfiguration.java MODIFY /james/server/branches/v2.3/src/java/org/apache/james/util/connection/ServerConnection.java MODIFY /james/server/branches/v2.3/src/test/org/apache/james/smtpserver/SMTPServerTest.java

Norman Maurer made changes - 12/Jan/07 11:07 AM

Fix Version/s	Next Major [ 10427 ]
Fix Version/s	Next Minor [ 12312136 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]
Fix Version/s		2.3.1-dev [ 12312150 ]

[ Permlink | « Hide ]

Danny Angus added a comment - 21/Nov/07 08:31 AM

Closing issue fixed in released version.

Danny Angus made changes - 21/Nov/07 08:31 AM

Status

Resolved [ 5 ]

Closed [ 6 ]