[JAMES-58] SqlResources.substituteSubString(): more than one replacement of one parameter may fail

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Component/s: James Core
• Environment: Operating System: All; Platform: All
• Bugzilla Id: 12855
• Assignee: Unassigned
• Reporter: Kai Heinecke
• Created: 20/Sep/02 18:57
• Updated: 06/Jun/04 21:27
• Resolved: 06/Jun/04 21:27

Description

in package org.apache.james.util.SqlResources.substituteSubString() you better should
write
while ( index > -1 )

{ [...] index = input.indexOf(find, index + /*replace_length*/ find_length); }

to find all occurrences of one parameter in the input
string.

TestCase:
public void testSubstituteSubString() {

String subst = null;

subst = sr.substituteSubString("${aa} ${aa}", "${aa}", "Test" );
assertEquals( "double
replacement one after another", "Test Test", subst );

subst =
sr.substituteSubString("${aa}${aa}", "${aa}", "Test" );
assertEquals( "double
replacement one after another without spaces", "TestTest", subst );

subst =
sr.substituteSubString("Ein ${k} ${k}", "${k}", "langerTest" );
assertEquals( "double
replacement where NEW is longer than OLD", "Ein langerTest langerTest", subst );

subst =
sr.substituteSubString("Ein ${keyword} ${keyword}", "${keyword}", "T" );

assertEquals( "double replacement where NEW is shorter than OLD", "Ein T T", subst );

subst
= sr.substituteSubString("Ein ${keyword} ${keyword}", "${keyword}", "Testwort12" );

assertEquals( "double replacement where NEW is as long as OLD", "Ein Testwort12 Testwort12",
subst );
}