[JAMES-3610] Use size units for SMTP and IMAP size limits

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: master, 3.6.0
• Fix Version/s: 3.7.0
• Component/s: configuration, IMAPServer, POP3Server, SMTPServer
• Assignee: Unassigned
• Reporter: Benoit Tellier
• Created: 07/Jul/21 07:17
• Updated: 12/Aug/21 06:57
• Resolved: 12/Aug/21 06:57

Description

Why ?

Today the following options can only be passed as integer:

• SMTP maxmessagesize option, in KB
• IMAP inMemorySizeLimit & literalSizeLimit in bytes

This is confusing (different default units) error prone (math error, eg when trying to configure it), unreadable (hard to tell at first glance if it is 10MB or 100MB), etc...

How?

Allow to specify an optional unit. Parse it. Use org.apache.james.util.Size for consistency.

Definition of done

• No backward compatility broken
• Hability to use size units there

Opportunity

POJOify SMTP, LMTP and POP3 configuration?

Issue Links

• links to: GitHub Pull Request #532