[JAMES-286] Exceeding maximum value with MAIL SIZE causes NullPointerException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.3.0
• Component/s: SMTPServer
• Assignee: Stefano Bagnara
• Reporter: Craig Raw
• Created: 18/May/04 08:37
• Updated: 21/Nov/07 08:31
• Resolved: 03/Jan/06 22:23

Description

There is a fairly simple problem with the doMailSize() method in SMTPHandler. When a MAIL FROM command is received with a SIZE value that exceeds the maxmessagesize value, the server sends a 552 response. It then attempts to log a message about the incident, and calls state.get(SENDER).toString() to form part of the log message.

Unfortuntely, state.put(SENDER, senderAddress) is only called later when the MAIL command is processed. Creating the log statement thus causes an NPE and the connection aborts.

The easy solution is to take this information out of the log message. I apologize for not including a patch, but I have lost track of which branch to patch against. However, I believe this problem is present in RC3.