[IVY-60] Vague error message due to coding style

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1
• Fix Version/s: 1.2
• Component/s: Ant
• Assignee: Xavier Hanin
• Reporter: Stephane Bailliez
• Due: 17/Nov/06
• Created: 29/Jul/05 18:02
• Updated: 29/Sep/05 16:02
• Resolved: 26/Nov/06 07:03

Description

In most Ant tasks, a validity check is performed on bean properties and ant properties to check for null.
Unfortunately everything is mixed in a hurry and the user does get a vague unhelpful message

For example in IvyPublish:

if (_module == null || _organisation == null || _revision == null)

{ throw new BuildException("empty or incomplete module revision id provided for publish: either call resolve, give paramaters to publish, or provide ivy.module, ivy.organisation and ivy.revision properties"); }

Provide a useless indication to the user of what is actually wrong. is it module ? organisation ? revision ? why does the message mention a revision id ? what should I do to fix that ?

Every required property should preferably be checked individually and send back a helpful message such as:

"Missing module property. It can either be set explicitely via the attribute 'module' or via 'ivy.module' property or a prior call to <resolve/>". YMMV