[IVY-249] Using Ivy 1.3.1, JAR files being copied are frequently corrupt (truncated)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.1
• Fix Version/s: 1.4-RC1
• Component/s: Core

Environment

Red Hat Enterprise Linux WS release 3 (Taroon Update 6)
java version "1.5.0_04"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_04-b05)
Java HotSpot(TM) Client VM (build 1.5.0_04-b05, mixed mode, sharing)
Apache Ant version 1.6.5 compiled on June 2 2005

• Assignee: Xavier Hanin
• Reporter: Michael Goddard
• Due: 17/Nov/06
• Created: 18/May/06 15:53
• Updated: 28/Aug/06 18:34
• Resolved: 26/Nov/06 07:04

Description

Ivy "resolve" tasks frequently result in truncated JAR files, causing the build to fail. I have observed this for the files being copied from the Web to the filesystem location, as well as for those being copied locally, for example from /opt/devel/ivy/ to $HOME/MyProject/lib/release/.

I was looking at Ivy, the source code for 1.3.1, and found a couple of things I questioned:

1. FileUtil.copy(File src, File dest, ...) did not ever check that, once the file was copied, src.length() == dest.length(). As an experiment, I added code to check this and throw an IOException if the sizes did not match.

2. Both CopyProgressEvent and TransferEvent classes have as fields the byte[] object used as the buffer during the copy. I can see no reason for that, and as an experiment, removed them, refactoring any affected classes as necessary.

I have a patch containing changes 1 and 2 and would like to contribute it.