[IMPALA-11380] impala-shell's VerticalOutputFormatter may incorrectly strip trailing whitespace

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Impala 4.2.0
• Fix Version/s: Impala 4.2.0
• Component/s: Clients
• Epic Color: ghx-label-10
• Assignee: XiangYang
• Reporter: Joe McDonnell
• Created: 21/Jun/22 23:27
• Updated: 05/Aug/22 16:18
• Resolved: 27/Jul/22 05:35

Description

From looking at VerticalOutputFormatter, it looks like it could suffer from the same issue that we saw in IMPALA-11332

 

    for r, row in enumerate(rows):
      if sys.version_info.major == 2:
        row = [val.encode('utf-8', 'replace') if isinstance(val, unicode) else val
            for val in row]
      writer.writerow(["************************************** " +
        str(r + 1) + ".row **************************************"])
      for c, val in enumerate(row):
        row[c] = self.column_names[c].rjust(self.column_name_max_len) + ": " + val
      writer.writerow(row)
    rows = temp_buffer.getvalue().rstrip() <------- here
    temp_buffer.close()

We should verify the problem and fix it. It seems like the rstrip() should follow the solution from IMPALA-11332 and strip only the newline.

See https://github.com/apache/impala/commit/c41e6941cafad453819b57e78b2083a3e64496e0

 

 

Issue Links

• is related to: IMPALA-11332 impala-shell strips trailing whitespace from csv output
• is related to: IMPALA-1682 Support '\G' in shell