[IMPALA-11313] impala-shell's PyPi form factor still suffers from IMPALA-10299

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: Impala 4.2.0
• Fix Version/s: Impala 4.2.0
• Component/s: Clients
• Epic Color: ghx-label-12
• Assignee: Joe McDonnell
• Reporter: Joe McDonnell
• Created: 23/May/22 16:31
• Updated: 28/Jun/22 18:23
• Resolved: 25/May/22 17:27

Description

The PyPi form factor for impala-shell gets its dependencies from the requirements.txt file, and that file uses "thrift==0.11.0". This Thrift version does not have fixes for  THRIFT-2087 or THRIFT-5303 , so it will not successfully run the tests added for IMPALA-10299/IMPALA-10145.

One option is to use a patched Thrift 0.11.0 for impala-shell's PyPi package. The other option is to use Thrift 0.14.2. My testing suggests that with a minor test fix, Thrift 0.14.2 works fine, even if we don't upgrade Thrift in other locations (i.e. the Thrift Python code generation is still generated by Thrift 0.11).

Issue Links

• causes: IMPALA-11343 impala-shell --ssl fails in PyPI install
• is related to: IMPALA-10299 Impala-shell hangs in printing partial UTF-8 characters
• is related to: IMPALA-10145 UnicodeDecodeError in Thrift 0.11.0 generated files
• is related to: IMPALA-11308 Shell tests fail when run with a python3 install of impala-shell