[HTTPCLIENT-646] HttpClient.executeMethod with absolute URI removes the Protocol from the hostConfiguration

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 3.1 RC1
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Thomas Mathis
• Created: 17/Apr/07 12:11
• Updated: 11/Aug/07 12:39
• Resolved: 18/Apr/07 07:46

Description

Testprogram (snippet):

public void test() throws IOException
{
String url = "https://www.somehost.com/somepath";
URL u = new URL(url);
Protocol protocol = new Protocol("https", new AcceptAllSSLProtocolSocketFactory(), port);
HttpClient httpClient = new HttpClient();
httpClient.getHostConfiguration().setHost(u.getHost(), port, protocol);
GetMethod m = new GetMethod(url);
httpClient.httpClient.executeMethod(m);
System.out.println("status=" + m.getStatusCode());
}

Suggested fix in method public int executeMethod(HostConfiguration hostconfig, final HttpMethod method, final HttpState state)

....
// make a deep copy of the host defaults
hostconfig = (HostConfiguration) hostconfig.clone();
if (uri.isAbsoluteURI()) {
//hostconfig.setHost(uri); <-- this line replaces the Protocol with the default one
hostconfig.setHost(uri.getHost(), uri.getPort(), hostconfig.getProtocol());
}
....