[HIVE-9956] use BigDecimal.valueOf instead of new in TestFileDump

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: File Formats
• Assignee: Alexander Pivovarov
• Reporter: Alexander Pivovarov
• Created: 13/Mar/15 06:32
• Updated: 18/May/15 19:50
• Resolved: 20/Mar/15 18:18

Description

TestFileDump builds data row where one of the column is BigDecimal
The test adds value 2.2222
There are 2 ways to create BigDecimal object.
1. use new
2. use valueOf

in this particular case
1. "new" will create 2.222199999999999953
2. valueOf will use the canonical String representation and the result will be 2.2222

Probably we should use valueOf to create BigDecimal object

TestTimestampWritable and TestHCatStores use valueOf

Issue Links

• is part of: HIVE-9809 Fix FindBugs found bugs in hive-exec
• links to: https://reviews.apache.org/r/32027/