[HIVE-7862] close of InputStream in Utils#copyToZipStream() should be placed in finally block

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.13.0
• Labels: patch
• Assignee: skrho
• Reporter: Ted Yu
• Created: 23/Aug/14 00:58
• Updated: 08/Mar/16 22:11

Description

In accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/Utils.java , line 278 :

  private static void copyToZipStream(InputStream is, ZipEntry entry, ZipOutputStream zos)
      throws IOException {
    zos.putNextEntry(entry);
    byte[] arr = new byte[4096];
    int read = is.read(arr);
    while (read > -1) {
      zos.write(arr, 0, read);
      read = is.read(arr);
    }
    is.close();

If read() throws IOException, is would be left unclosed.