[HIVE-6363] IllegalArgumentException is thrown instead of SQLException

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: 0.10.0, 0.11.0, 0.12.0
• Component/s: JDBC
• Labels: JDBC unit-test

Release Note

The HIVE JDBC driver now throws an SQLException when given an invalid URL. Previously, it through an IllegalArgumentException, which was not compatible with java.sql.DriverManager in OpenJDK 1.7. As a result of the change, the HIVE JDBC driver can now be used when other JDBC drivers are present in the classpath.

• Assignee: Unassigned
• Reporter: chandra sekhar gunturi
• Created: 04/Feb/14 07:09
• Updated: 23/Mar/15 21:22
• Resolved: 23/Mar/15 21:22

Description

parseURL in the following code is throwing IllegalArgumentException
http://svn.apache.org/viewvc/hive/trunk/jdbc/src/java/org/apache/hive/jdbc/Utils.java?view=markup

This is going to break other JDBC based connectors because java.sql.DriverManager doesn’t catch IllegalArgumentException while probing for correct Driver for a given URL.

A simple test case can have class.forName(org.apache.hive.jdbc.HiveDriver) (Loading hiveserver2 JDBC driver) followed by class.forName(org.apache.hadoop.hive.jdbc.HiveDriver)(Loading hiveserver JDBC driver).

In this case hiveserver connection will fail with BAD URL format for hiveserver. If you reverse the driver loading to hiveserver followed by hiveserver2, both the connections will be successful.

Following code in java.sql.DriverManager is causing the issue
[[
// Worker method called by the public getConnection() methods.
private static Connection getConnection(
// Walk through the loaded registeredDrivers attempting to make a connection.
// Remember the first exception that gets raised so we can reraise it.

for(DriverInfo aDriver : registeredDrivers) {
// If the caller does not have permission to load the driver then
// skip it.
if(isDriverAllowed(aDriver.driver, callerCL)) {
try {
Connection con = aDriver.driver.connect(url, info);
if (con != null) {
// Success!
println("getConnection returning " + aDriver.driver.getClass().getName());
return (con);
}
} catch (SQLException ex) {
if (reason == null)

{ reason = ex; } } }

else

{ println(" skipping: " + aDriver.getClass().getName()); } }

}
]]

Marking it as critical because this is going to restrict consuming JDBC driver in production environment where many drivers are loaded on requirement rather than statically loading all drivers.

Issue Links

• duplicates: HIVE-7935 Support dynamic service discovery for HiveServer2