[HIVE-19378] "hive.lock.numretries" Is Misleading

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.4.0, 3.0.0
• Component/s: HiveServer2
• Assignee: Alice Fan
• Reporter: David Mollitor
• Created: 01/May/18 19:44
• Updated: 27/Sep/18 00:00

Description

Configuration 'hive.lock.numretries' is confusing.  It's not actually a 'retry' count, it's the total number of attempt to try:

 

ZooKeeperHiveLockManager.java

do {
      lastException = null;
      tryNum++;
      try {
        if (tryNum > 1) {
          Thread.sleep(sleepTime);
          prepareRetry();
        }
        ret = lockPrimitive(key, mode, keepAlive, parentCreated, conflictingLocks);
...
} while (tryNum < numRetriesForLock);

So, from this code you can see that on the first loop, tryNum is set to 1, in which case, if the configuration num*retries* is set to 1, there will be one attempt total. With a retry value of 1, I would assume one initial attempt and one additional retry. Please change to:

while (tryNum <= numRetriesForLock);