[HIVE-16890] org.apache.hadoop.hive.serde2.io.HiveVarcharWritable - Adds Superfluous Wrapper

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Component/s: Serializers/Deserializers
• Assignee: David Mollitor Assign to me
• Reporter: David Mollitor
• Created: 13/Jun/17 17:22
• Updated: 22/May/18 23:57
• Resolved: 01/Dec/17 21:10

Description

Class org.apache.hadoop.hive.serde2.io.HiveVarcharWritable creates a superfluous wrapper and then immediately unwraps it. Don't bother wrapping in this scenario.

  public void set(HiveVarchar val, int len) {
    set(val.getValue(), len);
  }

  public void set(String val, int maxLength) {
    value.set(HiveBaseChar.enforceMaxLength(val, maxLength));
  }

  public HiveVarchar getHiveVarchar() {
    return new HiveVarchar(value.toString(), -1);
  }

  // Here calls getHiveVarchar() which creates a new HiveVarchar object with a string in it
  // The object is passed to set(HiveVarchar val, int len)
  //  The string is pulled out
  public void enforceMaxLength(int maxLength) {
    // Might be possible to truncate the existing Text value, for now just do something simple.
    if (value.getLength()>maxLength && getCharacterLength()>maxLength)
      set(getHiveVarchar(), maxLength);
  }