Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-15822

beeline ignore all sql under comment after semicolon

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.2.1, 2.1.1
    • None
    • Beeline, HiveServer2
    • None

    Description

      way to reproduce this error:
      beeline -u jdbc:hive2://localhost:10000 -n test -e "
      show databases;--some comment here
      show tables;"

      it will only execute 'show databases', and consider
      '--some comment here
      show tables;'
      as comment( all sql under the first comment appeared after semicolon).

      when the comment is also end with semicolon, the result will be right.

      the root cause is that beeline will only consider a entire command is inputed when a line is end with semicolon, otherwise if this line is not started with '--' or '#' beeline will combine it with next line until meet semicolon in the end. so actually the comment above is not removed(which causes the error). then beeline split the entire line by ';', so 'show databases' is recognized and executed,
      '--some comment here\n show tables' is considered a comment and discarded.

      my solution is to just remove comment before split by ';', the code can refer to solution 2 for similar issue :https://issues.apache.org/jira/browse/HIVE-15820

      Attachments

        1. HIVE-15822.patch
          0.6 kB
          muxin

        Issue Links

          Activity

            People

              muxin muxin
              muxin muxin
              Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: