[HIVE-10313] Literal Decimal ExprNodeConstantDesc should contain value of HiveDecimal instead of String

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.2.0
• Component/s: Query Processor
• Hadoop Flags: Reviewed
• Assignee: Chaoyu Tang
• Reporter: Chaoyu Tang
• Created: 13/Apr/15 12:01
• Updated: 18/May/15 19:48
• Resolved: 17/Apr/15 15:00

Description

In TyepCheckProcFactory.NumExprProcessor, the ExprNodeConstantDesc is created from strVal:

else if (expr.getText().endsWith("BD")) {
          // Literal decimal
          String strVal = expr.getText().substring(0, expr.getText().length() - 2);
          HiveDecimal hd = HiveDecimal.create(strVal);
          int prec = 1;
          int scale = 0;
          if (hd != null) {
            prec = hd.precision();
            scale = hd.scale();
          }
          DecimalTypeInfo typeInfo = TypeInfoFactory.getDecimalTypeInfo(prec, scale);
          return new ExprNodeConstantDesc(typeInfo, strVal);
        } 

It should use HiveDecmal:
return new ExprNodeConstantDesc(typeInfo, hd);