Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11891

DU#refresh should print the path of the directory when an exception is caught

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.9.0, 3.0.0-alpha4, 2.8.2
    • None
    • None
    • Reviewed

    Description

      the refresh() method DU is as follows,

        @Override
        protected synchronized void refresh() {
          try {
            duShell.startRefresh();
          } catch (IOException ioe) {
            LOG.warn("Could not get disk usage information", ioe);
          }
        }
      

      the log warning message should also be printing out the directory that failed.

      Attachments

        1. HDFS-11891.001.patch
          0.7 kB
          Chen Liang

        Activity

          Good catch! vagarychen +1 pending Jenkins.

          weichiu Wei-Chiu Chuang added a comment - Good catch! vagarychen +1 pending Jenkins.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 13m 37s trunk passed
          +1 compile 13m 50s trunk passed
          +1 checkstyle 0m 37s trunk passed
          +1 mvnsite 1m 13s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          -1 findbugs 1m 37s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings.
          +1 javadoc 0m 51s trunk passed
          +1 mvninstall 0m 48s the patch passed
          +1 compile 14m 14s the patch passed
          +1 javac 14m 14s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 1m 8s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 46s the patch passed
          +1 javadoc 0m 50s the patch passed
          +1 unit 8m 8s hadoop-common in the patch passed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          61m 53s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-11891
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870121/HDFS-11891.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3e6bddb7b055 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d81372d
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19637/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19637/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19637/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 37s trunk passed +1 compile 13m 50s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 13s trunk passed +1 mvneclipse 0m 18s trunk passed -1 findbugs 1m 37s hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. +1 javadoc 0m 51s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 14m 14s the patch passed +1 javac 14m 14s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 50s the patch passed +1 unit 8m 8s hadoop-common in the patch passed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 61m 53s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-11891 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12870121/HDFS-11891.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3e6bddb7b055 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d81372d Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/19637/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19637/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19637/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          arp Arpit Agarwal added a comment - - edited

          Committed for 2.8.0. Thank you for reporting and fixing this vagarychen. Thanks for the code review weichiu.

          arp Arpit Agarwal added a comment - - edited Committed for 2.8.0. Thank you for reporting and fixing this vagarychen . Thanks for the code review weichiu .
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11791 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11791/)
          HDFS-11891. DU#refresh should print the path of the directory when an (arp: rev bd6a2172e0442e5f02bad9bc5f0568045f57bd32)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DU.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11791 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11791/ ) HDFS-11891 . DU#refresh should print the path of the directory when an (arp: rev bd6a2172e0442e5f02bad9bc5f0568045f57bd32) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DU.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14057/)
          HDFS-11891. DU#refresh should print the path of the directory when an (xyao: rev 06c6c07be12349d06dc48baa486745c36b4de09e)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DU.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See https://builds.apache.org/job/Hadoop-trunk-Commit/14057/ ) HDFS-11891 . DU#refresh should print the path of the directory when an (xyao: rev 06c6c07be12349d06dc48baa486745c36b4de09e) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DU.java

          People

            vagarychen Chen Liang
            vagarychen Chen Liang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: